Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove routes that are no longer in the spec. #124

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

jonstacks
Copy link
Collaborator

Fixes #123

What

When an Edge route selector is modified, it creates a new route, but the old one is not cleaned up. This fixes a bug where old edge routes are not cleaned up

How

After we create/update the existing routes, delete any routes that are not in the new set of routes before syncing the status.

Breaking Changes

No

@jonstacks jonstacks requested a review from a team as a code owner January 27, 2023 07:39
@jonstacks jonstacks self-assigned this Jan 27, 2023
@github-actions github-actions bot added the area/controller Issues dealing with the controller label Jan 27, 2023
@jonstacks jonstacks merged commit bc7da9f into ngrok:main Jan 27, 2023
@jonstacks jonstacks deleted the remove-unused-routes branch January 27, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller Issues dealing with the controller
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old Routes not being removed when updating ingress
2 participants