Set ingress class default to false #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-bezek
force-pushed
the
alex/ingress-class-default-false
branch
from
02aad15 to
ea85054
Compare
|
We discussed the logic around the ingress controller. We agreed that we should prioritize these usecases:
But we should not try to support a special case where if you install it and its the only one, then it should try to act like a default since that is error prone and somewhat surprising. @jonstacks let me know if that summarizes our conversation |
alex-bezek
commented
Jan 18, 2023
Comment on lines
+27
to
+33
| # Remove finalizers from domains in namespace | ||
| kubectl get domains -A -o custom-columns=NAMESPACE:metadata.namespace,NAME:metadata.name --no-headers | \ | ||
| while read -r i | ||
| do | ||
| echo "kubectl get domains -n $i -o=json | jq '.metadata.finalizers = null' | kubectl apply -f -" | ||
| kubectl get domains -n $i -o=json | jq '.metadata.finalizers = null' | kubectl apply -f - | ||
| done |
There was a problem hiding this comment.
the domains hang the namespace deletion since they have finalizers
jonstacks
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Changes the default helm values for whether the ngrok ingress class should be the default from true to false. We should not assume we would be the default as it could cause problems if someone installs it in a cluster with another ingress controller.
How
Change the value in the values.yaml file
Breaking Changes
Technically yes, this is non-passive and reverses the behavior. If its installed in a cluster and its the only ingress class though, it will not pickup things by default anymore.
Our logic for how ingress classes are handled is here https://github.com/ngrok/kubernetes-ingress-controller/blob/main/internal/controllers/main.go#L29-L37 . With these helm defaults, you would install it in the cluster and would need to specify the ingress class on their ingress objects. Alternatively, if we set the default value for
ingressClass.createto false, then if this is the only controller installed https://github.com/ngrok/kubernetes-ingress-controller/blob/main/internal/controllers/main.go#L30 would make it handle ingress objects by default.Our logic for ingress classes may need to change up a bit at some point, but I haven't found any specifications on how it behaves in each scenario.