Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin app protect v5 version #7297

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 6, 2025

Proposed changes

  • pin nginx-plus-module-appprotect to the same version as app-protect-module-plus to 5.210
  • revert to ubuntu-22.04 runners
  • fix jq syntax for ubuntu-22.04

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 6, 2025 10:36
@github-actions github-actions bot added the docker Pull requests that update Docker code label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-4.0@eeb6911). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-4.0    #7297   +/-   ##
==============================================
  Coverage               ?   52.71%           
==============================================
  Files                  ?       89           
  Lines                  ?    20824           
  Branches               ?        0           
==============================================
  Hits                   ?    10977           
  Misses                 ?     9391           
  Partials               ?      456           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Feb 6, 2025
@pdabelf5 pdabelf5 merged commit 5b73e0c into release-4.0 Feb 6, 2025
70 checks passed
@pdabelf5 pdabelf5 deleted the chore/pin-app-protect-v5-version branch February 6, 2025 12:00
@pdabelf5 pdabelf5 removed github_actions Pull requests that update Github_actions code docker Pull requests that update Docker code labels Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants