Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and fix for NIC Pod failing to bind when NGINX exits unexpectedly #7295

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

AlexFenlon
Copy link
Contributor

Proposed changes

cherry pick for #7121

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@AlexFenlon AlexFenlon requested a review from a team as a code owner February 6, 2025 09:48
@github-actions github-actions bot added the go Pull requests that update Go code label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (release-4.0@eeb6911). Learn more about missing BASE report.

Files with missing lines Patch % Lines
cmd/nginx-ingress/main.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             release-4.0    #7295   +/-   ##
==============================================
  Coverage               ?   52.70%           
==============================================
  Files                  ?       89           
  Lines                  ?    20836           
  Branches               ?        0           
==============================================
  Hits                   ?    10981           
  Misses                 ?     9401           
  Partials               ?      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 changed the title [cherry-pick] Clean up and fix for NIC Pod failing to bind when NGINX exits unexpectedly (#7121) Clean up and fix for NIC Pod failing to bind when NGINX exits unexpectedly Feb 6, 2025
@pdabelf5 pdabelf5 added the bug An issue reporting a potential bug label Feb 6, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) February 6, 2025 12:09
@pdabelf5 pdabelf5 merged commit 0bf0b78 into release-4.0 Feb 6, 2025
70 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-nginx-fails-to-bind branch February 6, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

3 participants