Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update APIKey suppliedIn docs #7085

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Update APIKey suppliedIn docs #7085

merged 1 commit into from
Jan 8, 2025

Conversation

nginx-bot
Copy link
Contributor

Proposed changes

Fix APIKey Policy docs to highlight that suppliedIn is a mandatory parameter.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-bot nginx-bot requested review from a team as code owners January 8, 2025 16:33
@nginx-bot nginx-bot added documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch labels Jan 8, 2025
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Jan 8, 2025
@pdabelf5 pdabelf5 enabled auto-merge (squash) January 8, 2025 16:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7085/

@pdabelf5 pdabelf5 merged commit 8b7bd08 into release-4.0 Jan 8, 2025
23 checks passed
@pdabelf5 pdabelf5 deleted the cherry-pick-release-4.0-22a6f8c14959e17dbafb6b9ad76899d297a78dee branch January 8, 2025 16:37
@pdabelf5 pdabelf5 changed the title [cherry-pick] update APIKey suppliedIn docs Update APIKey suppliedIn docs Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nginx-bot @vepatel @AlexFenlon @pdabelf5