Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wafv5 docs #6261

Merged
merged 2 commits into from
Aug 20, 2024
Merged

fix wafv5 docs #6261

merged 2 commits into from
Aug 20, 2024

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 20, 2024 •
edited
Loading

Proposed changes

  • Fix some values for wafv5 helm args

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners August 20, 2024 14:46
@vepatel vepatel added the needs cherry pick Cherry pick this PR into a release branch label Aug 20, 2024
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 20, 2024
@github-actions GitHub Actions
Copy link

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/6261/

@vepatel vepatel merged commit 9c2687d into main Aug 20, 2024
29 checks passed
@vepatel vepatel deleted the docs/fix-wafv5 branch August 20, 2024 15:02
nginx-bot pushed a commit that referenced this pull request Aug 20, 2024
@vepatel @web-flow
fix wafv5 docs (#6261)
3e0d756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
documentation Pull requests/issues for documentation needs cherry pick Cherry pick this PR into a release branch
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @AlexFenlon @pdabelf5