Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove sarif artifact upload for images in feature branches #5850

Merged
merged 2 commits into from
Jun 25, 2024
Merged

remove sarif artifact upload for images in feature branches #5850

merged 2 commits into from
Jun 25, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jun 25, 2024 •
edited
Loading

Proposed changes

The sarif reports for image scans are saved in the Github artifact store on main & release branches, they are not needed on feature branches. However, the scan summaries are included in the PR workflow output.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner June 25, 2024 11:06
@github-actions github-actions bot added github_actions Pull requests that update Github_actions code chore Pull requests for routine tasks labels Jun 25, 2024
@pdabelf5 pdabelf5 enabled auto-merge (squash) June 25, 2024 12:18
@pdabelf5 pdabelf5 merged commit 1196c8c into main Jun 25, 2024
80 checks passed
@pdabelf5 pdabelf5 deleted the sarif-overwrite branch June 25, 2024 12:47
AlexFenlon pushed a commit that referenced this pull request Jul 1, 2024
@pdabelf5 @AlexFenlon
remove sarif artifact upload for images in feature branches (#5850)
939dff4
@AlexFenlon AlexFenlon mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks github_actions Pull requests that update Github_actions code
Projects
NGINX Ingress Controller
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pdabelf5 @oseoin @j1m-ryan @vepatel @AlexFenlon @jjngx