Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add string sanitisation for proxy-pass-headers & proxy-hide-headers #2730

Merged
merged 8 commits into from
Jun 1, 2022

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Jun 1, 2022

Proposed changes

This change adds string sanitisation to values provided by both proxy-pass-headers & proxy-hide-headers annotations used by the Ingress resource. This change is being added to prevent the use of special characters in these annotations.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from lucacome, ciarams87 and jjngx June 1, 2022 10:17
@github-actions github-actions bot added documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements labels Jun 1, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #2730 (350fcb1) into main (6681e2c) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2730      +/-   ##
==========================================
- Coverage   53.50%   53.49%   -0.01%     
==========================================
  Files          52       52              
  Lines       14754    14764      +10     
==========================================
+ Hits         7894     7898       +4     
- Misses       6597     6601       +4     
- Partials      263      265       +2     
Impacted Files Coverage Δ
internal/k8s/validation.go 98.08% <100.00%> (+0.06%) ⬆️
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
internal/k8s/configuration.go 95.47% <0.00%> (-0.39%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 great work

Copy link
Contributor

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@shaun-nx shaun-nx merged commit f3d905b into main Jun 1, 2022
@shaun-nx shaun-nx deleted the feature/annotationValidation branch June 1, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants