-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add string sanitisation for proxy-pass-headers & proxy-hide-headers #2730
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2730 +/- ##
==========================================
- Coverage 53.50% 53.49% -0.01%
==========================================
Files 52 52
Lines 14754 14764 +10
==========================================
+ Hits 7894 7898 +4
- Misses 6597 6601 +4
- Partials 263 265 +2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 great work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
This change adds string sanitisation to values provided by both proxy-pass-headers & proxy-hide-headers annotations used by the Ingress resource. This change is being added to prevent the use of special characters in these annotations.
Checklist
Before creating a PR, run through this checklist and mark each as complete.