atomic-server: refactor to rebuild from github source #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertchae
commented
Aug 1, 2024
albertchae
force-pushed
the
atomic-server-build-from-source
branch
2 times, most recently
from
c89d5ac to
df71b00
Compare
jleightcap
reviewed
Aug 2, 2024
albertchae
force-pushed
the
atomic-server-build-from-source
branch
from
edf334a to
1558458
Compare
This refactor builds atomic-server using the separately packaged atomic-browser and then the github source. Not only is this more reflective of the real build process used, but it is helpful when trying to debug atomic-server by building a fork with additional logging, which we did while working on ngi-nix#220 Previously we were building atomic-server from the published crate, which is usually "from source". But in this case that meant only the rust source, and separately built web assets were packaged into the crate. This can be verified by running `curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tv` and checking for the `assets_tmp` directory.
albertchae
force-pushed
the
atomic-server-build-from-source
branch
from
1558458 to
5c87a3a
Compare
fricklerhandwerk
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor builds atomic-server using the separately packaged
atomic-browser and then the github source. Not only is this more
reflective of the real build process used, but it is helpful when trying
to debug atomic-server by building a fork with additional logging, which
we did while working on #220
Previously we were building atomic-server from the published crate,
which is usually "from source". But in this case that meant only the
rust source, and separately built web assets were packaged into the
crate. This can be verified by running
curl -L 'https://crates.io/api/v1/crates/atomic-server/0.37.0/download' | tar -tvand checking for the
assets_tmpdirectory.Part of #15