Optimize MapCropper

[bmarchant]

Certain output file formats will crop data on output so the MapCropper isn't necessary during the read operation, this used to just be OGR formats and now includes GeoJSON output files.

The MapCropper object deletes ways that fall outside of the bounds one-by-one using the RemoveWayByEid map visitor. When each way is deleted the OsmMap object rebuilds the _index member which is a costly operation. Instead of doing that, now the OsmMap::bulkRemoveWays method deletes a list of ways all at once and then rebuilds the index afterwards only one time.

Closes #5693

[mschicker]

This looks good, and like it will be a great speedup!

I think you should add a comment in OsmMap.cpp to the bulkRemoveWays function header that explains the removeFully parameter. From reading the function, it looks like this switch decides whether or not the given ways should be removed from the map AND relations, or just the map.

[mschicker]

Tastefully done! Approved!