Optimize centroid calculation rubber sheet #5627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubbersheeting buildings used the centroid of the polygon as the tie-point but converted the building element into a
geos::geom::Geometry
object before calling the built-ingetCentroid()
function. This conversion is heavy so a heuristic approach of using the average of all coordinates in the element, recursively for any relations. While the binary.rs
file changed in theAlignApplyCmdTest
unit test, the results were the same when the input was rubbersheeted.While in the
ElementGeometryUtils
code, thecalculateLength
function had a similar issue of converting linear ways togeos::geom::Geometry
objects. I used simple iterative distance calculations on way segments to replace the conversion.