make overpass grail query only traverse down #5601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The traverse up was meant to grab any relations containing the coastline or admin boundary. These "extensive" features (can be part of very large areas) are not amenable to conflation so are then excluded from the dataset pulled in from Overpass. However in a recent examination of the data by @maxgrossman it seemed that the untagged nodes of coastline ways were being left in the output.
Not sure why this would be unless traversing up to no parent relation then breaks the traverse down.
Edit:
I find that union'ing with
( );
after tranversing up fixes this.