Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make overpass grail query only traverse down #5601

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Conversation

maxgrossman
Copy link
Contributor

@maxgrossman maxgrossman commented Mar 14, 2023

The traverse up was meant to grab any relations containing the coastline or admin boundary. These "extensive" features (can be part of very large areas) are not amenable to conflation so are then excluded from the dataset pulled in from Overpass. However in a recent examination of the data by @maxgrossman it seemed that the untagged nodes of coastline ways were being left in the output.

Not sure why this would be unless traversing up to no parent relation then breaks the traverse down.

Edit:
I find that union'ing with ( ); after tranversing up fixes this.

[out:json];
(node({{bbox}});<;>;)->.all;
(
   relation({{bbox}})[natural=coastline];>;
   (way({{bbox}})[natural=coastline];<;);>;
   relation({{bbox}})[boundary=administrative];>;
   (way({{bbox}})[boundary=administrative];<;);>;
   node({{bbox}})[boundary=administrative];
)->.exclude;
(.all; - .exclude;);
out meta;

Copy link
Contributor

@brianhatchl brianhatchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

me likey

@brianhatchl brianhatchl merged commit e22c857 into master Mar 16, 2023
@brianhatchl brianhatchl deleted the updated_grail_query branch March 16, 2023 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants