Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation conf files to the node-export server #5528

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Add translation conf files to the node-export server #5528

merged 1 commit into from
Jan 20, 2023

Conversation

mattjdnv
Copy link
Contributor

Make it have the same functionality as hoot-services does.

@mattjdnv mattjdnv requested a review from brianhatchl December 13, 2022 16:52
@mattjdnv mattjdnv self-assigned this Dec 13, 2022
brianhatchl
brianhatchl reviewed Dec 16, 2022
View reviewed changes
Copy link
Contributor

@brianhatchl brianhatchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like there are two ways to set options per translation scheme. There is this <Schema>Export.conf file, but also translationConfig.json property exportOptions.
We probably don't need both right?

@brianhatchl
Copy link
Contributor

Trying to use DNC in node-export (and also via Hoot services export) and getting
Error running convert: Function call 'getDbSchema' returned an error.

I tried this because it's one schema with an Export conf file.

@mattjdnv
Copy link
Contributor Author

mattjdnv commented Jan 6, 2023

Re-testing this prior to merging

@mattjdnv mattjdnv merged commit 822b5b7 into master Jan 20, 2023
@mattjdnv mattjdnv deleted the 5527_nodeExport branch January 20, 2023 17:14
jordanmurray35 pushed a commit that referenced this pull request Feb 1, 2023
@mattjdnv @jordanmurray35
Added code to look for a conf file when exporting. (#5528)
eaa58f4 
refs: #5527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianhatchl brianhatchl brianhatchl left review comments

Assignees

@mattjdnv mattjdnv

Labels
Category: Core Category: Translation Priority: Medium Status: Ready for Test Type: Feature Type: Maintenance Type: Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattjdnv @brianhatchl