Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute conflation changes building geometry #5395

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Attribute conflation changes building geometry #5395

merged 3 commits into from
Jul 28, 2022

Conversation

bmarchant
Copy link
Contributor

  • Create new AttributeBuildingMerger that doesn't modify any geometries for attribute conflation.
  • Create new UpdateMeasurementTagsVisitor that updates width, height, and feature_area tags based on their current geometry size (since these can be transferred in attribute conflation and give the wrong values)
  • Updated MetadataTags
  • Other code cleanup

Refs #5389

@bmarchant bmarchant self-assigned this Jul 27, 2022
@bmarchant bmarchant merged commit dc8c4fe into master Jul 28, 2022
@bmarchant bmarchant deleted the attribute_conflation_changes_5389 branch July 28, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmarchant bmarchant

Labels
Category: Core Priority: High Type: Bug Type: Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bmarchant