Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for ASAN #5393

Merged
merged 3 commits into from
Aug 5, 2022
Merged

Added support for ASAN #5393

merged 3 commits into from
Aug 5, 2022

Conversation

mattjdnv
Copy link
Contributor

Adding libasan and flags for the DEBUG build

Cannot run `hoot` or `HootTest` in DEBUG mode without ASAN failures.  Don't enable ASAN by default.  Updated note.
@bmarchant bmarchant merged commit e4998b5 into master Aug 5, 2022
@bmarchant bmarchant deleted the 5392 branch August 5, 2022 15:28
@bmarchant
Copy link
Contributor

Leaving ASAN enabled for DEBUG builds causes unit tests to fail (because some are based on output and cannot handle ASAN output) and it takes 5x the time to run as compared to when it is run without. One single test, WayJoinerConflateTest::runAdvancedConflateTest took 10 seconds to run (2 seconds without) and produced 1765 lines of ASAN output for 29912 bytes leaked in 384 allocations. Enabling this will prove very useful for removing these allocation issues but shouldn't be a regular part of the everyday DEBUG build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants