Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sherlock match conflation command for IDs #5390

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Update sherlock match conflation command for IDs #5390

merged 1 commit into from
Jul 25, 2022

Conversation

jordanmurray35
Copy link
Contributor

  • This PR is for sherlock to retain the original IDs from the data source when running the conflation (match only) command

@jordanmurray35 jordanmurray35 self-assigned this Jul 25, 2022
@jordanmurray35 jordanmurray35 requested a review from bmarchant July 25, 2022 19:08
bmarchant
bmarchant approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@bmarchant bmarchant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bmarchant bmarchant merged commit 9b2fd7d into master Jul 25, 2022
@bmarchant bmarchant deleted the sherlock-hoot-updates branch July 25, 2022 21:21
@jordanmurray35 jordanmurray35 restored the sherlock-hoot-updates branch July 27, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarchant bmarchant bmarchant approved these changes

Assignees

@jordanmurray35 jordanmurray35

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jordanmurray35 @bmarchant