-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make translation directory locations modular #5380
Conversation
refs: # 5379
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I did re-order the translation list to put the newer / more popular ones first. |
Not sure why this same core test is failing:
It seems to pass locally when run in isolation with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what to do about the test failure
This looks like a change that happened with the upgrade of the |
ok, I definitely had not re-provisioned since that update |
@mattjdnv BLUF: if you merge Long version: Because |
Added code to the translationServer to use a hoot config variable for translation directory locationsAdding to hoot-services next. Am trying to have one way to specify translation directories at run time to make deployments easier.Got rid of the config var and now it searches
$HOOT_HOME/translations*
looking fortranslationConfig.json
filesThis file is a combination of the
DefaultTranslations.json
file and the TranslationServer config file.There is a bit of cleanup to do to remove the last of the hardcodedtranslations-local
stuff.And, as usual, the documentation needs an update as well.