Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS logging no longer picks up script name #5320

Merged
merged 6 commits into from
Apr 13, 2022
Merged

JS logging no longer picks up script name #5320

merged 6 commits into from
Apr 13, 2022

Conversation

bmarchant
Copy link
Contributor

All calls to v8::Script::Compile from C++ were missing the v8::ScriptOrigin parameter that supplies the script name. Both instances of that call are now fixed to use the correct script origin information.

Closes #5018

@bmarchant bmarchant self-assigned this Apr 12, 2022
@bmarchant bmarchant merged commit ac487bf into master Apr 13, 2022
@bmarchant bmarchant deleted the log_js_update_5018 branch April 13, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmarchant bmarchant

Labels
Category: Core Priority: Medium Type: Bug Type: Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JS logging no longer picks up script name
1 participant
@bmarchant