5289 hootjs error messages #5307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts/core/MergeNodes.js is executed from within the translations directory. In particular, ConfPath::search(...) was looking in the local directory, before checking the specified searchDir. This was a problem for script execution in the translations dir, because translations contains a Poi.js file collides with the (proper) rules/Poi.js file
adds two tests that are currently failing will pass when #5289 is fixed
…oint/hootenanny into 5289_hootjs_error_messages
…Node, instead of just always reporting "UnsupportedException"
… 5289_hootjs_error_messages
|
It looks like this PR is failing on the new ElementMerge tests I added here for TDD. I'll investigate. |
|
this last failing cucumber test has been a problem child. I say ✔️ to merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HootExceptionJS to allow detailed error messages to bubble up to Node/Javascript
Fixes #5289