-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDSv71 and other fixes #5269
TDSv71 and other fixes #5269
Conversation
translations/TDSv70.js
Outdated
@@ -33,7 +33,7 @@ hoot.require('SchemaTools'); | |||
hoot.require('tds70'); | |||
hoot.require('tds70_schema'); | |||
hoot.require('tds70_rules'); | |||
// hoot.require('config'); | |||
hoot.require('config'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see other scripts removing this commented out line. Is it really needed here? or should it be removed too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed along with some other commented out config.xxx
lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, lots of diffs to the translation tests, but is any translation behavior really changing?
The main behavior changes:
|
I'm still trying to figure out why CircleCI is failing during It seems to be the last one in the list each time:
|
After ssh-ing into Circle CI, I think it is running out of resources when trying to run the schema generation in parallel. A better option may be to just commit the generated schema files. |
Yes!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😎
NOTE: These are still valid targets in the Makefile.hoot so that they can be updated if needed refs: #5260
Need to do some final QA then can merge. |
Fixes:
|
Re-enable TDSv71 and various translation fixes
@brianhatchl I modified some of the NodeJs translation tests and added TDSv71 ones