Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5202 make understand json #5261

Merged
merged 6 commits into from
Feb 28, 2022
Merged

5202 make understand json #5261

merged 6 commits into from
Feb 28, 2022

Conversation

maxgrossman
Copy link
Contributor

adds new function loadMapFromJSONString to the MapIoJs.h.
this gets used in the translation server, allowing it to accept json flavor osm data.

@brianhatchl
Copy link
Contributor

I have seen this cucumber test failure a few times since #5249 was merged.

[](https://jenkins.nomedev.com/blue/organizations/jenkins/Hootenanny/detail/PR-5261/3/pipeline/#step-89-log-22)[](https://jenkins.nomedev.com/blue/organizations/jenkins/Hootenanny/detail/PR-5261/3/pipeline/#step-89-log-23)[](https://jenkins.nomedev.com/blue/organizations/jenkins/Hootenanny/detail/PR-5261/3/pipeline/#step-89-log-24)[](https://jenkins.nomedev.com/blue/organizations/jenkins/Hootenanny/detail/PR-5261/3/pipeline/#step-89-log-25)Unable to find visible link or button "Add Reference Dataset" (Capybara::ElementNotFound)
./features/step_definitions/custom_steps.rb:456:in `/^I press "([^"]*)"$/'
./features/support/hooks.rb:43:in `block in <top (required)>'
features/paste_attributes.feature:22:in `And I press "Add Reference Dataset"'

The failure is intermittent, so I've just re-run the jenkins job 🤷

Copy link
Contributor

@brianhatchl brianhatchl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ✌️ legit 🥈 🛑 🕺

Copy link
Contributor

@bmarchant bmarchant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@maxgrossman maxgrossman merged commit 7fba7a0 into master Feb 28, 2022
@maxgrossman maxgrossman deleted the 5202_make_understand_json branch February 28, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants