Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More graceful error handling #5530

Closed
mattjdnv opened this issue Dec 13, 2022 · 0 comments · Fixed by #5531
Closed

More graceful error handling #5530

mattjdnv opened this issue Dec 13, 2022 · 0 comments · Fixed by #5531

Comments

@mattjdnv
Copy link
Contributor

Currently, if you specify a config option that does not exist - depreciated, renamed or just a type - Hoot throws an exception and dies.
Remove the exception throwing and replace it with an error message, drop the variable and move on

@mattjdnv mattjdnv self-assigned this Dec 13, 2022
mattjdnv added a commit that referenced this issue Dec 13, 2022
bmarchant added a commit that referenced this issue Jan 13, 2023
* Converted the exception to an error message

refs: #5530

* Converted a JSON settings file exception to an error.

refs: #5530

* Fix infinite loop when bad option is encountered

* Copyright :shakes-fist:

* Capture the log output to a string if desired, compare that in the Settings unit tests.

* Copyright

Co-authored-by: Ben Marchant <[email protected]>
jordanmurray35 pushed a commit that referenced this issue Feb 1, 2023
* Converted the exception to an error message

refs: #5530

* Converted a JSON settings file exception to an error.

refs: #5530

* Fix infinite loop when bad option is encountered

* Copyright :shakes-fist:

* Capture the log output to a string if desired, compare that in the Settings unit tests.

* Copyright

Co-authored-by: Ben Marchant <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant