Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RemoveEmptyRelationsVisitor should be applied to output #2062

Closed
bwitham opened this issue Jan 18, 2018 · 2 comments
Closed

RemoveEmptyRelationsVisitor should be applied to output #2062

bwitham opened this issue Jan 18, 2018 · 2 comments

Comments

@bwitham
Copy link
Contributor

bwitham commented Jan 18, 2018

To suppress empty output relations as reported in the attached slides here: https://github.com/DigitalGlobe/VGI-team-repo/issues/1244

I thought that it was already being applied, but apparently not.

@bwitham bwitham added this to the Hootenanny 2018-01-31 milestone Jan 18, 2018
@bwitham bwitham self-assigned this Jan 18, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062 - in order to deal with relation children
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062
bwitham added a commit that referenced this issue Jan 23, 2018
1. refs #2062
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
bwitham added a commit that referenced this issue Jan 23, 2018
@bwitham
Copy link
Contributor Author

bwitham commented Jan 23, 2018

Applied the visitor, but its not correctly deleting relations that are children of other relations when the child appears after the parent. So, changing the visitor over to an op so it can recurse through and delete all relation children.

bwitham added a commit that referenced this issue Jan 24, 2018
bwitham added a commit that referenced this issue Jan 24, 2018
bwitham added a commit that referenced this issue Jan 24, 2018
@bwitham
Copy link
Contributor Author

bwitham commented Jan 25, 2018

merged

@bwitham bwitham closed this as completed Jan 25, 2018
brianhatchl added a commit that referenced this issue Jun 26, 2023
  > Add option to clip grail pull data to extent (#2062)
  < indent clip checkbox to align
  < add option to clip grail pull to extent
  < replace with hoot2x (reverting lock update)
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < dist/build updates
  < use https to fetch github dependency, refresh lock versions
brianhatchl added a commit that referenced this issue Jun 26, 2023
* add a clip option to grail pull using two-step command

and gpkg as intermediate file

* copyright

* Submodule hoot-ui-2x d2bbe9541..85e1c6bcb:
  > indent clip checkbox to align
  > add option to clip grail pull to extent
  > replace with hoot2x (reverting lock update)

# Conflicts:
#	hoot-ui-2x

* remove duplicate comment

* Submodule hoot-ui-2x 85e1c6bcb...eb2e97aaf:
  > Add option to clip grail pull data to extent (#2062)
  < indent clip checkbox to align
  < add option to clip grail pull to extent
  < replace with hoot2x (reverting lock update)
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < dist/build updates
  < use https to fetch github dependency, refresh lock versions
brianhatchl added a commit that referenced this issue Sep 26, 2023
  > update build info
  > Docker updates (#2050)
  > update build info
  > Bump semver from 5.7.1 to 5.7.2 (#2063)
  > Bump word-wrap from 1.2.3 to 1.2.4 (#2064)
  > Treat folders with null parent id as being under root (id=0) (#2065)
  > update build info
  > Add option to clip grail pull data to extent (#2062)
  < replace with hoot2x (reverting lock update)
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < dist/build updates
  < use https to fetch github dependency, refresh lock versions
brianhatchl added a commit that referenced this issue Sep 27, 2023
* add docker development environment

* newlines

* do not make build dep of up. this way build can be separate way to hard rebuild images

* just mount hoot-ui-2x dir

* removing extra lines

* adding missing and fixing incorrect volumes

* let us attach a remote debugger for services

* only copy files/war when we build them

* add db_host_osmapi to DatabaseConfigLocal target

* correct osmapi host name

* handle older versions of docker/docker-compose

* git ignore .npm

* update hoot-ui-2x submodule

* add missing new line

* Updates to docker PR to work in fresh git repo clone (#5614)

* legacy hoot submodule hoot-ui/ has been removed

* don't need hootenanny-id in core-services container

add parent submodule git volume to frontend to allow npm deps
from github to work

* use node 14 to match core-services, install git for use in npm

* don't need deploy frontend to tomcat

add a make clean target
just deploy exploded webapp, not war file

* use unprotected auth endpoint as health check

* don't need hootenanny-id dir in tomcat

* add clean property, remove UI mention from build services property

* Submodule hoot-ui-2x 9df7cba39..ba88f7ad9:
  > dist/build updates
  > use https to fetch github dependency, refresh lock versions

* restore FORCE to always attempt VersionDefines.h rebuild

* this seems to be causing ./HOOT_VERSION_GEN to loop

* don't need this

* revert changes to see if it affects 'make archive'

* try .PHONE instead of FORCE

* Submodule hoot-ui-2x 521e79585..d2bbe9541:
  > Merge remote-tracking branch 'origin/hoot2x' into docker_updates

* wip: add some docker command refs

* need to run configure each time because generated Makefile can get stale

* need to call this too when core builds services

* Move versions out to .env file and expose in docker-compose.yml (#5675)

* consolidate lib version configs in VagrantProvisionVars.sh for now

* add other ARG values

* move versions to .env template file

* missed adding this template file

* downgrade glpk

* use PG 14

* don't need bash

* these are written in by Makefile.docker

* PG 13 is now working for me

* Submodule hoot-ui-2x 7e0099d18...804b1502f:

  > update build info
  > Docker updates (#2050)
  > update build info
  > Bump semver from 5.7.1 to 5.7.2 (#2063)
  > Bump word-wrap from 1.2.3 to 1.2.4 (#2064)
  > Treat folders with null parent id as being under root (id=0) (#2065)
  > update build info
  > Add option to clip grail pull data to extent (#2062)
  < replace with hoot2x (reverting lock update)
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < Merge remote-tracking branch 'origin/hoot2x' into docker_updates
  < dist/build updates
  < use https to fetch github dependency, refresh lock versions

---------

Co-authored-by: Brian Hatchl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant