Changed watch task according to feedback #145
Conversation
Updated tests to address issue where jQuery was being loaded before Angular and thus, Angular was using jQuery & not jqLite, causing false positives. Closes ngOfficeUIFabric#123.
Renamed and combined tasks. Updated description. Alpha- sort. Prettify help output.
|
One step closer to perfection :). |
|
Looking good! Checking out the watch and live dev stuff now, but wanted to mention this other part... The new formatting of the help makes it very hard to read. Adding a newline between every single option makes reading the options that go with the task quite unreadable. Can we address / revert this? Previously I mentioned that I thought we should wrap long lines & indent them so things don't wrap. the task we're using to build the help only indents options 1 space under the task... when you add a lot of vertical space, that indentation is hard to read. IMHO, there is wrapping that doesn't need to be there. For instance, the Here's what I see (also tried in the stock terminal window at 80 & 120 char wide): As you can see, I'm having to scroll a good bit up to see the first few tasks when I run help. IMHO this isn't necessary and we need to remove all this wrapping & additional extra vertical space. The only thing we want to address are descriptions that wrap. For instance, here's a screenshot of how it was. Notice the
|
|
BTW, everything else looks great! Let's tweak the way the help is displayed as this is a pretty big change and then I think we're good. |
|
Hmm... Ok, so I remove extra line breaks for task description and add line breaks only if description length more than 120 symbols. |
|
Totally agree we can’t make it great for every case & 120 isn’t a hard & fast rule… I’m cool with 80 because I get many take the default width which is 80… so wrapping at 80 seems pretty standard. For me the information density with so many line breaks & empty lines just made it hard to consume. |
|
Awesome job guys! Can't wait to rebase my repo with these changes :) The fact that with tslint issues the specs don't run is blocking me developing. |
andrewconnell
added
waffleio:in-progress
and removed
work-in-progress
waffleio:in-progress
labels
… to fit 120 chars (whole line).
|
One more attempt :). |
|
Awesome... looks great! Adding to my list of things to merge. Closes #49 |
Rename `watch` task to `live-dev`. Update `live-dev` task to (1) perform first pass of all things before watching for changes; (2) to only run tests within the test file that was updated; (3) never fail on errors in any checks (vet, test, build)... always run each of these; (4) optionally use browsersync to do live dev of demos with the new `--serve` flag. Due to big changes to build process, when updating forks, recommend following process to clean out all old JavaScript from old tasks: ``` gulp clean tsc -p ./ ``` Closes #49. Closes #145.
|
Manually merged to |
|
Ihaaa! Merged! :)) |
Solves #49