This repository was archived by the owner on Jun 14, 2018. It is now read-only.
Update - uif-contextual-menu attribute validation #99
Assignees
Labels
Comments
andrewconnell
changed the title
andrewconnell
pushed a commit
that referenced
this issue
Jan 23, 2016
Added attribute validation and error logging to the console to address directive guidelines [#7](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#directive-attribute-validation) & [#8](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#error-messages). Also updated `package.json` to explicitly set Angular version 1.4.8 as investigating issue introduced in Angular 1.4.9 (not sure if Angular issue or with ngOfficeUiFabric). Closes #99. Closes #112.
andrewconnell
pushed a commit
that referenced
this issue
Jan 23, 2016
Added attribute validation and error logging to the console to address directive guidelines [007](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#directive-attribute-validation) & [008](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#error-messages). Also updated `package.json` to explicitly set Angular version 1.4.8 as investigating issue introduced in Angular 1.4.9 (not sure if Angular issue or with ngOfficeUiFabric). Closes #99. Closes #112.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The v0.2.0 will introduce two new directive guidelines, 007 & 008, that address error message format & validating directive attributes with deterministic values (boolean, enum, number). Please update the directive to add error checking and ideally where appropriate, add an enum for set options.
Attributes to check for this directive:
uif-typeuif-is-disableduif-is-selectedThe text was updated successfully, but these errors were encountered: