Skip to content
This repository was archived by the owner on Jun 14, 2018. It is now read-only.

Update guidelines & add issues for new directive guideline #93

Closed
2 tasks done
andrewconnell opened this issue Jan 15, 2016 · 0 comments
Closed
2 tasks done

Update guidelines & add issues for new directive guideline #93

andrewconnell opened this issue Jan 15, 2016 · 0 comments

Comments

@andrewconnell
Copy link
Member

New guideline for directives: if a public property / attribute on a directive takes a finite set of options, even if it is optional / default, the directive must:

  • include an enum with the options
  • validate the value of the attribute passed in is valid & if not, log an error in the console using $log.error()

This was recently implemented on the uif-icon directive... currently in the dev branch. See how it's done here:

This will require the following

  • add a new guideline to the directive guidelines doc
  • create enhancement issues for existing directives... assigned to original author
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant