Skip to content
This repository was archived by the owner on Jun 14, 2018. It is now read-only.

Update - uif-table attribute validation #101

Closed
andrewconnell opened this issue Jan 16, 2016 · 2 comments
Closed

Update - uif-table attribute validation #101

andrewconnell opened this issue Jan 16, 2016 · 2 comments

Comments

@andrewconnell
Copy link
Member

The v0.2.0 will introduce two new directive guidelines, 007 & 008, that address error message format & validating directive attributes with deterministic values (boolean, enum, number). Please update the directive to add error checking and ideally where appropriate, add an enum for set options.

You can see how uif-icon does this in the dev branch today for an example. The guideline doc also has an example of this.

Attributes to check for this directive:

  • uif-selected
  • uif-orderasc ??
@waldekmastykarz
Copy link
Member

👍

@waldekmastykarz
Copy link
Member

uif-orderasc is not an attribute that you can set on the directive. It's a property on the scope and it can only bet set through code where it's defined as boolean.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants