This repository was archived by the owner on Jun 14, 2018. It is now read-only.
Update - uif-spinner attribute validation #100
Assignees
Labels
Comments
andrewconnell
pushed a commit
that referenced
this issue
Jan 24, 2016
Added attribute validation and error logging to the console to address directive guidelines [007](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#directive-attribute-validation) & [008](https://github.com/ngOfficeUIFabric/ng-officeuifabric/blob/master/docs/guides/DIRECTIVE-CHECKLIST.md#error-messages). BREAKING CHANGE: uif-spinner's `uif-spinnersize` attribute changed to `uif-size`. Change your code from this: ```html <uif-spinner uif-spinnersize="large"></uif-spinner> ``` To this: ```html <uif-spinner uif-size="large"></uif-spinner> ``` Closes #100. Closes #102. Closes #120.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The v0.2.0 will introduce two new directive guidelines, 007 & 008, that address error message format & validating directive attributes with deterministic values (boolean, enum, number). Please update the directive to add error checking and ideally where appropriate, add an enum for set options.
Attributes to check for this directive:
uif-spinner-sizeThe text was updated successfully, but these errors were encountered: