Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not found text is not used for custom tags #234

Closed
evxn opened this issue Feb 4, 2018 · 2 comments
Closed

Not found text is not used for custom tags #234

evxn opened this issue Feb 4, 2018 · 2 comments

Comments

@evxn
Copy link
Contributor

evxn commented Feb 4, 2018 •
edited
Loading

Expected behaviour

"No items found" text is visible if addTag is set to true.

Actual behaviour

Narrow stripe is visible.
ng-select-bug

DEMO https://stackblitz.com/edit/angular-xy1avv

More Info

ng-select version: 0.17.0

browser: Version 61.0.3163.100 (Official Build) Built on Ubuntu , running on Ubuntu 17.10 (64-bit)

reproducible in demo page: YES
@evxn
Copy link
Contributor Author

evxn commented Feb 4, 2018

The reason is this line:
4149375#diff-68265c9310f2ae9e060ab288eb5e8491R64
Which I suppose was intended behavior. But it looks just weird.

@evxn
Copy link
Contributor Author

evxn commented Feb 4, 2018 •
edited
Loading

My suggestion is to change
<div class="ng-menu" *ngIf="showNoItemsFound() && !addTag">
to
<div class="ng-menu" *ngIf="showNoItemsFound() && !showAddTag()">

new behavior demo:
ng-select-show-add-tag

evxn added a commit to evxn/ng-select that referenced this issue Feb 4, 2018
@evxn
fix: Not found text is not used for custom tags ng-select#234
7e22d26
@evxn evxn mentioned this issue Feb 4, 2018
Merged
varnastadeus pushed a commit that referenced this issue Feb 5, 2018
@evxn @varnastadeus
fix: Not found text is not used for custom tags #234 (#235)
fbd5f5c
jakemdunn pushed a commit to jakemdunn/ng-select that referenced this issue Oct 16, 2018
@evxn @varnastadeus
fix: Not found text is not used for custom tags ng-select#234 (ng-sel…
63c0175 
…ect#235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@evxn @varnastadeus