Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPE_KARMEN_TRACY updated #33

Merged
merged 4 commits into from
Jan 23, 2025
Merged

DPE_KARMEN_TRACY updated #33

merged 4 commits into from
Jan 23, 2025

Conversation

sofiasiamp
Copy link
Member

No description provided.

FlorianSchw
FlorianSchw requested changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@FlorianSchw FlorianSchw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the DPE file, for variable TOT_PA_QX the harmo comment should be MET-min/week or MET-min/wk as everything else is usually in English language for units. MET-min/Wo seems to be reference for German word of week ("Woche").
The rest seems good!

FlorianSchw
FlorianSchw approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@FlorianSchw FlorianSchw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems good now!

@sofiasiamp sofiasiamp merged commit 1b827f0 into main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorianSchw FlorianSchw FlorianSchw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofiasiamp @FlorianSchw @tbosei