Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump artic #343

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Bump artic #343

merged 2 commits into from
Dec 1, 2022

Conversation

tavareshugo
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/viralrecon branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • [] Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This should close #341

I have:

  • Updated modules by running nf-core modules update artic/minion; nf-core modules update artic/guppyplex
  • Added a note about this to CHANGELOG.md
  • Ran the test locally as nextflow run . -profile test_full_nanopore,singularity --outdir results_nanopore -- completed successfully with no errors.

maxulysse
maxulysse approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Nov 30, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 48ca31d

+| ✅ 148 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   2 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-11-30 15:40:50

@maxulysse
Copy link
Member

closes #341

@maxulysse
Copy link
Member

we have 2 tests failing, but they were already failing in dev, so I'll try to fix it in a coming PR

@maxulysse maxulysse merged commit 1bbb046 into nf-core:dev Dec 1, 2022
@drpatelh drpatelh mentioned this pull request Mar 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tavareshugo @maxulysse