Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow module names with notations as in conda #961

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Conversation

Erkison
Copy link
Contributor

@Erkison Erkison commented Mar 24, 2021

Allow module names with non [a-z] characters as in conda to enable finding of conda dependencies with the Anaconda API. But remove the characters in the code for consistent naming convention.

PR checklist

Closes #956

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@Erkison Erkison linked an issue Mar 24, 2021 that may be closed by this pull request
@codecov

This comment has been minimized.

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this! I wonder if it would make more sense to trigger the prompt when the bioconda lookup fails instead though? eg. If nothing is found then prompt the user to ask if they want to enter a different bioconda package name.

Sound sensible?

@drpatelh
Copy link
Member

That sounds perfect!

@Erkison
Copy link
Contributor Author

Erkison commented Mar 24, 2021

Sounds great. I’d try to implement this now.

@Erkison Erkison requested a review from ewels March 24, 2021 13:25
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! If feeling OCD we could probably add a command line flag for this too (I think it's nice to be able to run without prompts if desired) but can leave that to a future PR as we're about to push a minor release and would be nice to squeeze this in..

@ewels ewels merged commit 93fccc4 into nf-core:dev Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-core modules create does not allow module names with dashes
3 participants