Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.10.1 patch release #708

Merged
merged 15 commits into from
Jul 30, 2020
Merged

Version 1.10.1 patch release #708

merged 15 commits into from
Jul 30, 2020

Conversation

ewels
Copy link
Member

@ewels ewels commented Jul 30, 2020

See #707 for changes.

dev to master for the 1.10.1 patch release 🚀

@codecov
Copy link

codecov bot commented Jul 30, 2020

Codecov Report

Merging #708 into master will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   82.04%   81.98%   -0.07%     
==========================================
  Files          13       13              
  Lines        2746     2753       +7     
==========================================
+ Hits         2253     2257       +4     
- Misses        493      496       +3     
Impacted Files Coverage Δ
nf_core/__main__.py 61.81% <42.85%> (-0.87%) ⬇️
nf_core/sync.py 62.56% <75.00%> (+0.30%) ⬆️
nf_core/lint.py 91.86% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0fbe2...765d84e. Read the comment docs.

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deja vu

@ewels ewels marked this pull request as draft July 30, 2020 19:50
@ewels ewels added the WIP Work in progress label Jul 30, 2020
@ewels ewels removed the WIP Work in progress label Jul 30, 2020
@ewels ewels marked this pull request as ready for review July 30, 2020 19:51
@ewels ewels requested review from apeltzer, jpfeuffer, mashehu and a team July 30, 2020 19:55
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ewels ewels dismissed apeltzer’s stale review July 30, 2020 20:00

Requested change made

@ewels ewels merged commit 2ccb064 into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants