Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template: Run awsfulltest after release, and with dev revision on PRs to master #3485

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

mirpedrol
Copy link
Member

Close #3462

@mirpedrol mirpedrol requested a review from mashehu March 7, 2025 10:04
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 76.64%. Comparing base (f7207a5) to head (81a2795).

Files with missing lines Patch % Lines
nf_core/pipelines/lint/actions_awsfulltest.py 66.66% 1 Missing ⚠️
Additional details and impacted files

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mirpedrol mirpedrol requested a review from ningyuxin1999 March 7, 2025 10:05
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can then remove the approval checking steps. they were anyway too buggy.

@mirpedrol
Copy link
Member Author

we can then remove the approval checking steps. they were anyway too buggy.

If we remove this the tests will run two times, one when the first review is approved and submitted and one when the second one is submitted. Is this a no go? or we are fine with it?

@mashehu
Copy link
Contributor

mashehu commented Mar 11, 2025

better then a wonky check before. but maybe we can check if there is already something in the S3 bucket and only run if it is empty or something like that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants