-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieving module information of input and output and EDAM ontology from bio.tools #3418
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
f14d145
first implementation of retrieving module information of input and ou…
mirpedrol 8f3d2dc
first implementation of retrieving module information of input and ou…
mirpedrol 56f37f8
run pre-commit
mirpedrol 91c67f1
run prettier after creating the module
mirpedrol 38e7784
fix pytests
mirpedrol 3edcecc
fix typing
mirpedrol 135f5da
more typing fixes
mirpedrol 284bfa6
add pytests for components utils
mirpedrol fbe857e
restructure components tests
mirpedrol 27d1996
Apply suggestions from code review
mirpedrol bde7a3b
use bio.tools info to create main.nf for modules template
mirpedrol d2631b1
add EDAM comments and suggestions from review
mirpedrol 7bae22e
add missing ontologies to meta.yml when using nf-core lint --fix
mirpedrol 1735c9e
use pattern for output channel element in meta.yml
mirpedrol d730b08
update pytest
mirpedrol 5cef9f6
remove 'type' assignment for backwards python compatibility
mirpedrol f4a42b5
Merge branch 'dev' into get-edam-ontology
mirpedrol 76e56c5
try ignoring errors when deleting a modules work directory created wi…
mirpedrol 6f442c2
more tryes to fix pytest
mirpedrol 5301e1b
run test_unstable_snapshot first and don't remove_readonly
mirpedrol 2ed1eb9
use EDAM tsv instead of python library
mirpedrol 8a6d45f
add edam comments to hardocded template example and when linting
mirpedrol ca93755
don't add empty comment and comma to meta.yml
mirpedrol 2795d58
add log.info messages
mirpedrol 3dead1e
fix nf-test components test
mirpedrol 47036ff
fix more pytests
mirpedrol 1e574fe
fix test path
mirpedrol File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if it isn't better to always return
None
if we don't get a correct entry, like we do in the function aboveThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had another look and since this is the value we use for the
meta.yml
it is easier to return an empty string that we can directly add to the file. That way, we avoid having to check if it'sNone
.