Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change questionary ask to unsafe_ask to cancel execution on keyboard interupts #1241

Merged
merged 2 commits into from
Jul 29, 2021

Conversation

ErikDanielsson
Copy link
Contributor

A few of the commands weren't exiting properly or at all due to the KeyboardInterupts being caught by the ask function from questionary. They are now changed to unsafe_ask so the process exits on keyboard interupts. Should close #1237.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ErikDanielsson ErikDanielsson changed the title Change questionary ask to unsafe_ask to cancel execution on KeyboardInterupt Change questionary ask to unsafe_ask to cancel execution on keyboard interupts Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1241 (b7f69e6) into dev (ca7980c) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1241      +/-   ##
==========================================
- Coverage   67.85%   67.84%   -0.02%     
==========================================
  Files          50       50              
  Lines        5560     5560              
==========================================
- Hits         3773     3772       -1     
- Misses       1787     1788       +1     
Impacted Files Coverage Δ
nf_core/modules/bump_versions.py 79.54% <ø> (ø)
nf_core/modules/create.py 78.86% <ø> (ø)
nf_core/modules/remove.py 79.59% <ø> (ø)
nf_core/modules/update.py 7.50% <ø> (ø)
nf_core/modules/lint/main_nf.py 84.82% <0.00%> (-1.38%) ⬇️
nf_core/modules/lint/module_version.py 84.61% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca7980c...b7f69e6. Read the comment docs.

@ErikDanielsson ErikDanielsson merged commit 7336331 into nf-core:dev Jul 29, 2021
@ErikDanielsson
Copy link
Contributor Author

Thanks @maxulysse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants