Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of lib to merge tools v2.13.1 #357

Merged
merged 15 commits into from
Apr 2, 2024
Merged

Get rid of lib to merge tools v2.13.1 #357

merged 15 commits into from
Apr 2, 2024

Conversation

JoseEspinosa
Copy link
Member

Closes #356

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • CHANGELOG.md is updated.

@github-actions GitHub Actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @JoseEspinosa,

It looks like this pull-request is has been made against the JoseEspinosa/nf-core-atacseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the JoseEspinosa/nf-core-atacseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@JoseEspinosa JoseEspinosa changed the base branch from master to dev March 20, 2024 12:34
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 20, 2024 •
edited
Loading

nf-core lint overall result: Failed ❌

Posted for pipeline commit eb1285a

+| ✅ 175 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   4 tests had warnings |!
-| ❌   6 tests failed       |-

❌ Test failures:

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.bamtools_filter_pe_config
  • nextflow_config - Config default ignored: params.bamtools_filter_se_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-02 09:08:05

@JoseEspinosa JoseEspinosa marked this pull request as ready for review March 20, 2024 14:26
bjlang
bjlang requested changes Mar 22, 2024
View reviewed changes
subworkflows/local/utils_nfcore_atacseq_pipeline/main.nf
return reference_text
}

def methodsDescriptionText(mqc_methods_yaml) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this function used?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is added by the template to make possible to dump the reference e.g. here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And yes I think we can leave this to the template merge

bjlang
bjlang approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@bjlang bjlang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoseEspinosa JoseEspinosa merged commit 36227a2 into nf-core:dev Apr 2, 2024
10 of 11 checks passed
This was referenced Jul 3, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjlang bjlang bjlang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get template v2.13.1 (get rid of lib)
2 participants
@JoseEspinosa @bjlang