Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code snippets and examples in manual need to use NIAC2014 attributes #443

Closed
prjemian opened this issue Feb 12, 2016 · 14 comments
Closed

code snippets and examples in manual need to use NIAC2014 attributes #443

prjemian opened this issue Feb 12, 2016 · 14 comments
Assignees
Labels

Comments

@prjemian
Copy link
Contributor

  • add NIAC2014 attributes to NeXus history
  • revise code snippets and data examples to use default/default/signal/axes/*_indices attributes
  • consider adding a flowchart graphic to identify default data for plotting (useful for code developers who might encounter any of the three methods)
@prjemian prjemian added the task label Feb 12, 2016
@prjemian prjemian self-assigned this Feb 12, 2016
@prjemian
Copy link
Contributor Author

in napi.rst there are references to NAPI F90 Utility Routines

  • NXUfindsignal : Searches the currently open group for a data item with the specified SIGNAL attribute.
  • ``NXUfindaxis` : Searches the currently open group for a data item

Will the NAPI F90 Utility Routines be refactored to consider the NIAC2014 attributes? Handle separately in the code repository.

@prjemian
Copy link
Contributor Author

in NeXus/definitions/manual/source/examples

these instances of signal need to be resolved by someone familiar with the code:

napi-example.c:            NXputattr (file_id, "signal", &i, 1, NX_INT32);
napi-example.f77:              status = NXputattr (file_id, 'signal', 1, 1, NX_INT32)
napi-example.f90:            if (NXputattr (file_id, "signal", 1) /= NX_OK) stop
nxh5write.c: *            @signal=1
nxh5write.c:  int counts[LENGTH], i, rank, signal;
nxh5write.c:   * set the signal=1 attribute 
nxh5write.c:  attid = H5Acreate(dataid,"signal", atttype, atts, H5P_DEFAULT);
nxh5write.c:  signal = 1;
nxh5write.c:  H5Awrite(attid, atttype, &signal);

@prjemian
Copy link
Contributor Author

There is a note that the f77 interface will no longer be developed.

@prjemian
Copy link
Contributor Author

need to regenerate the simpl3D data with the revised code

@prjemian
Copy link
Contributor Author

in rules.rst the Simple scan with area detector example should be checked for the @axes attribute. the 2nd and 3rd dimensions have not available axes datasets to be plotted and should be assumed that any client will understand this.

see examples/simplescanarea.txt

@prjemian
Copy link
Contributor Author

Also, scour for missing _indices attributes in various examples and snippets

prjemian added a commit that referenced this issue Feb 13, 2016
NXdata group also needs attributes for all of the {axes}_indices
prjemian added a commit that referenced this issue Feb 14, 2016
also changed some axes attributes but here there are some harder
decisions

need to look for attributes primary, secondary, and axis

need to consider and add {axis}_indices attributes, and review any
previous editing
prjemian added a commit that referenced this issue Feb 14, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 18, 2016
prjemian added a commit that referenced this issue Feb 19, 2016
prjemian added a commit that referenced this issue Feb 19, 2016
prjemian added a commit that referenced this issue Feb 19, 2016
prjemian added a commit that referenced this issue Feb 19, 2016
@prjemian
Copy link
Contributor Author

all contributed definitions with NXentry and/or NXdata groups have been refactored

prjemian added a commit that referenced this issue Feb 19, 2016
consider breaking into two files with the part that describes how to find the plottable data
prjemian added a commit that referenced this issue Feb 19, 2016
prjemian added a commit that referenced this issue Feb 19, 2016
@prjemian
Copy link
Contributor Author

need to add a few graphic files to illustrate the different ways to find the plottable data, check up on #436, then ready for pull request

@zjttoefs
Copy link
Contributor

I'm in agreement with all the changes made until yesterday to examples and code snippets. I had a glance yesterday and that looks very good.
The changes to the application definitions are going a bit far to do them without discussion. Especially since we're still none the wiser how to handle versioning there.

I would propose I merge the non application definition changes and put the other ones on a separate branch to look at individually.

@zjttoefs zjttoefs added the telco label Feb 19, 2016
prjemian added a commit that referenced this issue Feb 19, 2016
…d definitions back to master branch, will post changes in separate branch
@prjemian
Copy link
Contributor Author

I'll issue a PR when this branch is ready

@prjemian
Copy link
Contributor Author

see PR #448 (work of #447)

@zjttoefs
Copy link
Contributor

Discussed in Telco. Should be merged to master.
Thanks Pete!

@prjemian
Copy link
Contributor Author

fixed in #453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants