Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cargo lock error #297

Closed
wants to merge 1 commit into from
Closed

Fix Cargo lock error #297

wants to merge 1 commit into from

Conversation

duc-nx
Copy link
Contributor

@duc-nx duc-nx commented Dec 9, 2024 •
edited
Loading

Summary:

Test Plan:

@duc-nx duc-nx force-pushed the pr297 branch 6 times, most recently from 1e66373 to 0697c9b Compare December 9, 2024 20:14
@duc-nx duc-nx requested review from sjudson and slumber December 9, 2024 20:39
@slumber
Copy link
Contributor

slumber commented Dec 9, 2024

Have you tested jolt?

sjudson
sjudson requested changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@sjudson sjudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following on from @slumber, let's stick with 1.77.0 for the time being: there may be a lot of edge cases to upgrading to 1.80.0, so let's just get the CI working and we can consider the upgrade later.

@duc-nx duc-nx force-pushed the pr297 branch 6 times, most recently from 1fe98b2 to d611ddb Compare December 9, 2024 22:55
Fix Cargo lock error
8c95baf 
Summary:

Test Plan:
@sjudson
Copy link
Contributor

sjudson commented Dec 10, 2024

Closing in preference of alternate approach.

@sjudson sjudson closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjudson sjudson sjudson requested changes

@slumber slumber Awaiting requested review from slumber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duc-nx @slumber @sjudson