Add Benchmark guide to doc #271
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Looks good to me, but I'd wait on @yoichi-nexus's approval as well before merging
|
The doc works after 0.2.3 |
|
I'm following the doc again. |
|
Okay, I updated the doc which contain the instruction to generate project and show the Cargo.toml in 26e913a |
There was a problem hiding this comment.
Now I can follow the doc and run the commands! There is one problem: cargo run --release 2>/dev/null doesn't print anything. I could not find performance numbers. My Vercel comment is about this.
Probably the document should explain how to see the performance numbers.
There was a problem hiding this comment.
I'm seeing a compilation error
--> src/main.rs:18:53
|
18 | fn prove_execution(pp: &PP, prover: Nova<Local>) -> nexus_sdk::nova::seq::Proof {
| --------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `Proof`, found `()`
| |
| implicitly returns `()` as its body has no tail or `return` expression
19 | prover.prove(pp).expect("failed to prove program");
| - help: remove this semicolon to return this value
when I run cargo run --release
|
It should work now. I left a typo after modifying the code according to the soft clippy suggestion. ac87b79 |
Summary: Add Benchmark.md up to 13-th Fibonacci number.
Summary:
Add Benchmark.md up to 13-th Fibonacci number.