Skip to content

Commit

Permalink
Update supernova/src/circuits/nova/pcd/compression/secondary/conversi…
Browse files Browse the repository at this point in the history
…on.rs


comment style

Co-authored-by: Kristian Sosnin <[email protected]>
  • Loading branch information
tess-eract and slumber authored Jan 19, 2024
1 parent f9aca11 commit 9bb6517
Showing 1 changed file with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -75,10 +75,10 @@ where
Ok(FF::from_uniform_bytes(&le_bytes))
}

/// converts a point of an arkworks short weierstrass curve to one on the corresponding halo2 curve.
/// note that the `CurveAffine` trait from `halo2curves` is for short weierstrass curves only.
/// this only works when the base field is a prime field.
/// returns an error if the curves have different equations, different base fields,
/// Converts a point of an arkworks short weierstrass curve to one on the corresponding halo2 curve.
/// Note that the `CurveAffine` trait from `halo2curves` is for short weierstrass curves only.
/// This only works when the base field is a prime field.
/// Returns an error if the curves have different equations, different base fields,
/// or different scalar fields/cofactors, or if the point is the point at infinity.
#[allow(dead_code)]
pub fn ark_to_halo2_group<AG, HG, const N: usize>(p: Affine<AG>) -> Result<HG, GroupConversionError>
Expand Down

0 comments on commit 9bb6517

Please sign in to comment.