Skip to content

Commit

Permalink
Commit to preprocessed trace first (#278)
Browse files Browse the repository at this point in the history
  • Loading branch information
yoichi-nexus authored and sjudson committed Feb 5, 2025
1 parent 5a02673 commit 682f2b3
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions prover/src/machine2/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ use stwo_prover::{
};

use nexus_vm::trace::Trace;
use trace::{sidenote::SideNote, PreprocessedTraces, ProgramStep};
use trace::{sidenote::SideNote, ProgramStep};

pub mod chips;
pub mod components;
Expand Down Expand Up @@ -74,7 +74,14 @@ impl<C: MachineChip + Sync> Machine<C> {
config, &twiddles,
);

// Fill columns.
// Fill columns of the preprocessed trace.
let preprocessed_trace = trace::PreprocessedTraces::new(log_size);
let mut tree_builder = commitment_scheme.tree_builder();
let _preprocessed_trace_location =
tree_builder.extend_evals(preprocessed_trace.circle_evaluation());
tree_builder.commit(prover_channel);

// Fill columns of the original trace.
let mut prover_traces = trace::Traces::new(log_size);
let mut prover_side_note = SideNote::default();
let program_steps = trace
Expand Down Expand Up @@ -102,19 +109,12 @@ impl<C: MachineChip + Sync> Machine<C> {
tree_builder.commit(prover_channel);

let lookup_elements = LookupElements::draw(prover_channel);
let preprocessed_trace = PreprocessedTraces::new(log_size);
let mut tree_builder = commitment_scheme.tree_builder();
let interaction_trace =
C::fill_interaction_trace(&prover_traces, &preprocessed_trace, &lookup_elements);
let _interaction_trace_location = tree_builder.extend_evals(interaction_trace);
tree_builder.commit(prover_channel);

// Fill columns of the preprocessed trace.
let mut tree_builder = commitment_scheme.tree_builder();
let _preprocessed_trace_location =
tree_builder.extend_evals(preprocessed_trace.circle_evaluation());
tree_builder.commit(prover_channel);

let component = MachineComponent::new(
&mut TraceLocationAllocator::default(),
MachineEval::<C>::new(log_size, lookup_elements),
Expand Down

0 comments on commit 682f2b3

Please sign in to comment.