Add Operation InputType and OutputType helper methods #21
Conversation
nexus/operation.go
Outdated
| @@ -36,6 +38,13 @@ func (r operationReference[I, O]) Name() string { | |||
| return string(r) | |||
| } | |||
|
|
|||
| func (r operationReference[I, O]) IsInputAssignable(i any) bool { | |||
There was a problem hiding this comment.
Not sure this needs to be on every operation reference (nor does IsOutputAssignable). If you had a InputType() reflect.Type that could maybe make a bit more sense, but anyone can obtain the generic of the operation reference via reflection. IMO having a helper for Go reflection is unnecessary for this public API.
Can just update the Temporal side to use reflection if it needs to check whether something is assignable, same as it would for any generic API it would need to do a similar check for. I wouldn't expect types with generics to provide this helper.
There was a problem hiding this comment.
I don't think it's possible to get the generic input type in Go. I tried this before and ended up blocked on golang/go#54393.
Maybe there's another way you're aware of that I'm not.
There was a problem hiding this comment.
I see, my mistake. I think InputType() reflect.Type and OutputType() reflect.Type would be better general-purpose methods to add (or Types() (input reflect.Type, output reflect.Type)).
bergundy
changed the title
| @@ -36,6 +40,16 @@ func (r operationReference[I, O]) Name() string { | |||
| return string(r) | |||
| } | |||
|
|
|||
| func (operationReference[I, O]) InputType() reflect.Type { | |||
| var zero [0]I | |||
| return reflect.TypeOf(zero).Elem() | |||
There was a problem hiding this comment.
| return reflect.TypeOf(zero).Elem() | |
| return reflect.TypeOf((*I)(nil)).Elem() |
This may also work (untested), but what you have is fine/cheap too, no need to change.
Useful helper methods, we need this in the Temporal Go SDK to validate inputs when starting an operation from a workflow.