fix: crash when generating CSV/TSV output #1507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can ignore unknown categories here. We check correctness of this input elsewhere.
This allows to erase current CSV/TSV column config settings, such that the default set of columns is selected. This is done to enable new column categories released in Nextclade 3.8.0.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivan-aksamentov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1492
Prompted by the user report over email, this solves a couple of bugs in the CSV/TSV output code. These are both improper lookups/insertions into data structures.
Additionally, I incremented the version in the local storage entry name in Nextclade Web, such that all settings are reset on user's machines after release. This will make the new columns introduced in #1492 (released in 3.8.0) to be enabled by default (otherwise entries which are missing are treated as "disabled", which should probably be changed).
These bugs highlight the need for some love and refactoring of the CSV output generation code, which is one of the oldest modules in the codebase.