feat(web): Support Safari >= 16.0 again #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason we deprecated Safari was that it didn't support shared web workers Since v16.0 shared web workers are supported so we no longer need to show the browser warning Alternatively, we could discourage less loudly, saying that Safari is not tested (for >=16) while still erroring for lower versions.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@corneliusroemer There has been problems beyond web workers, for example with CSS. Do the |
|
Everything looks good on Safari 17.2 - I can keep using it there for a bit to see how robust it is. 
|
ivan-aksamentov
added a commit
that referenced
this pull request
Mar 5, 2024
Followup of #1348 There are reports that WebWorkers don't work in Nextclade on Safari 16.3. I was able to confirm that they do work on 16.5, so I am setting this version as the lowest supported. I don't have access to versions lower than that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason we deprecated Safari was that it didn't support shared web workers Since v16.0 shared web workers are supported so we no longer need to show the browser warning Alternatively, we could discourage less loudly, saying that Safari is not tested (for >=16) while still erroring for lower versions.