Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement GitHub URL parsing, fix related bugs #1334

Merged
merged 7 commits into from
Dec 12, 2023

Conversation

ivan-aksamentov
Copy link
Member

  • re-implement parsing of full GitHub URLs and GitHub shortcuts used as input in URL params. See various possible combinations in this unit test
  • all URL params accepting URLs can now also accept full GitHub URLs and GitHub shortcuts, including dataset-server, dataset-url, input-fasta, other individual input files (input-*)
  • fix UI hanging on inifinite loading screen when using dataset-url
  • improve error messages when using malformed URLs

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextclade ✅ Ready (Inspect) Visit Preview Dec 12, 2023 11:02am

@ivan-aksamentov ivan-aksamentov force-pushed the feat/web-revamp-url-params branch from 659fd9a to 6df41f1 Compare December 12, 2023 10:49
@ivan-aksamentov ivan-aksamentov changed the title Re-implement URL param parsing, fix bugs Re-implement GitHub URL parsing, fix related bugs Dec 12, 2023
@ivan-aksamentov ivan-aksamentov merged commit 639f3eb into master Dec 12, 2023
17 checks passed
@ivan-aksamentov ivan-aksamentov deleted the feat/web-revamp-url-params branch December 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant