Skip to content

Commit

Permalink
fix(ci): Upload all CLI build outputs
Browse files Browse the repository at this point in the history
Include hidden files since our sole path pattern is a hidden "file".
Apparently this counts even though the files the pattern matches aren't
hidden.

GitHub made this big breaking change of excluding hidden files without
bumping the major version number of actions/upload-artifact.¹  It,
rightfully so, caused a ruckus at the time and continues to be a gift
that keeps on giving.

The only other actions/upload-artifacts usage, in
.github/workflows/web.yml, seemingly isn't affected even though the path
contains a hidden directory.  Perhaps because in that case there are a
few more directory components after it?

¹ <https://github.com/actions/upload-artifact/releases/tag/v4.4.0>

Resolves: <#1532>
  • Loading branch information
tsibley committed Oct 15, 2024
1 parent ed94c59 commit 037a7e7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/cli.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ jobs:
with:
name: out-${{ matrix.arch }}
path: ./.out/*
include-hidden-files: true


run-unit-tests:
Expand Down

0 comments on commit 037a7e7

Please sign in to comment.