Merge pull request #133: Small improvements

nextstrain · Mar 10, 2023 · 852036e · 852036e
2 parents d59452c + 6da7696
commit 852036e
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -202,7 +202,7 @@ RUN pip3 install git+https://github.com/cov-lineages/pango-designation.git@19d9a
 RUN pip3 install pysam==0.19.1
 
 
-# 4. Add unpinned programs and Nextstrain components
+# 4. Add unpinned programs
 
 # Allow caching to be avoided from here on out by calling
 # docker build --build-arg CACHE_DATE="$(date)"

diff --git a/README.md b/README.md
@@ -114,8 +114,7 @@ To add a software program to `nextstrain/base`, follow steps in this order:
 
 If possible, pin the software to a specific version. Otherwise, add the
 download/install/build command to the section labeled with `Add unpinned
-programs and Nextstrain components` to ensure the latest version is included in
-every Docker image build.
+programs` to ensure the latest version is included in every Docker image build.
 
 ### Best practices
 

diff --git a/devel/build b/devel/build
@@ -58,7 +58,6 @@ docker buildx build \
     --builder "$builder" \
     --platform "$platform" \
     --build-arg CACHE_DATE \
-    --build-arg GIT_REVISION \
     --cache-from "$BUILDER_IMAGE:latest" \
     --cache-from "$BUILDER_IMAGE:$tag" \
     --cache-from "$registry/$BUILDER_IMAGE:latest" \
@@ -72,7 +71,6 @@ docker buildx build \
     --target final \
     --builder "$builder" \
     --platform "$platform" \
-    --build-arg CACHE_DATE \
     --build-arg GIT_REVISION \
     --cache-from "$BUILDER_IMAGE:latest" \
     --cache-from "$BUILDER_IMAGE:$tag" \