-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genome annotation improvements #961
Conversation
Input trees with non-labelled internal nodes always printed a WARNING but this was going to stdout rather than stderr. This in turn allowed the tests to pass when they shouldn't have. Note: I think this warning should be a fatal error in almost every conceivable case. To describe ancestral sequences without knowing which node they correspond to in the input tree is a recipe for confusion.
The following test is failing (locally & on CI), but it's also failing for me on current master (where CI passes...). @victorlin any ideas?
|
CI is temp patched with #962, just need to rebase onto latest master here and other PRs. Or run again when it's not the first of the month 🙃 |
For a detailed write-up of the bug which motivated this commit, see #881. By storing the (nucleotide) genome annotation in the node-data produced from augur-ancestral we make this information available for export. Previously this information was only exported by `augur translate` which was problematic for workflows which didn't perform translation. No changes are needed to `augur export v2` (which may now process multiple "annotations" blocks) due to the behavior of `NodeData.deep_add_or_update` which will recurse into dicts in annotation blocks and when confronted with non-dict values which already exist overwrite them. This poses a potential problem where two node-data JSONs which (e.g.) define different `annotations['nuc']` coordinates will not raise any error and the output coodinates are dependent on the order the node-data JSONs were provided to `augur export v2`. Closes #881.
a404eb1
to
8ef9753
Compare
(No changes, but force-pushed with a new SHA to trigger CI) |
Codecov Report
@@ Coverage Diff @@
## master #961 +/- ##
==========================================
+ Coverage 59.36% 61.53% +2.17%
==========================================
Files 43 52 +9
Lines 6014 6794 +780
Branches 1539 1768 +229
==========================================
+ Hits 3570 4181 +611
- Misses 2185 2348 +163
- Partials 259 265 +6
Continue to review full report at Codecov.
|
For a detailed write-up of the bug which motivated this PR, see
#881.
The main work is in the 2nd commit:
By storing the (nucleotide) genome annotation in the node-data produced
from augur-ancestral we make this information available for export.
Previously this information was only exported by
augur translate
whichwas problematic for workflows which didn't perform translation.
No changes are needed to
augur export v2
(which may now processmultiple "annotations" blocks) due to the behavior of
NodeData.deep_add_or_update
which will recurse into dicts inannotation blocks and when confronted with non-dict values which already
exist overwrite them. This poses a potential problem where two node-data
JSONs which (e.g.) define different
annotations['nuc']
coordinateswill not raise any error and the resulting coodinates are dependent on
the order the node-data JSONs were provided to
augur export v2
.Closes #881.