Disable header timeout on mobile #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
force-pushed
the
enh/noid/disable-header-timeout
branch
from
f0a4d77 to
4419286
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
szaimen
added
3. to review
szaimen
requested review from
julien-nc,
Pytal,
artonge,
skjnldsv,
jancborchardt and
nimishavijay
artonge
reviewed
Jul 19, 2021
|
@szaimen thank you for the explanation! :) Hiding the controls is not only valuable for when you are in a slideshow though, but also generally when viewing photos and you want to just focus on the pictures. Yes, mobile is an issue, but there a different solution is required. Ideally it would be like this:
So basically, I’d rather have us improve the mobile/touch experience rather than reducing down the desktop experience. Hope that makes sense? cc @nimisha-vijay |
|
@jancborchardt Thanks for the feedback! So I'll come up with a different solution that disables the timeout only for mobile :) |
szaimen
force-pushed
the
enh/noid/disable-header-timeout
branch
2 times, most recently
from
03b9694 to
996715a
Compare
szaimen
commented
Jul 19, 2021
juliusknorr
reviewed
Jul 19, 2021
szaimen
force-pushed
the
enh/noid/disable-header-timeout
branch
from
996715a to
30f8efe
Compare
github-actions
bot
force-pushed
the
enh/noid/disable-header-timeout
branch
from
30f8efe to
6b18b3b
Compare
szaimen
force-pushed
the
enh/noid/disable-header-timeout
branch
from
6b18b3b to
b8a1a09
Compare
skjnldsv
reviewed
Jul 19, 2021
szaimen
added
2. developing
szaimen
force-pushed
the
enh/noid/disable-header-timeout
branch
2 times, most recently
from
798b8dc to
fac14c5
Compare
github-actions
bot
force-pushed
the
enh/noid/disable-header-timeout
branch
from
fac14c5 to
335a794
Compare
julien-nc
previously requested changes
Jul 19, 2021
szaimen
force-pushed
the
enh/noid/disable-header-timeout
branch
from
335a794 to
0e7ec4f
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: szaimen <[email protected]> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
github-actions
bot
force-pushed
the
enh/noid/disable-header-timeout
branch
from
0e7ec4f to
5b865e2
Compare
|
Everything done. Please re-review :) |
szaimen
added
3. to review
Pytal
approved these changes
Jul 19, 2021
szaimen
dismissed
julien-nc’s stale review
The requested changes were implemented.
julien-nc
approved these changes
Jul 19, 2021
|
/backport to stable22 |
backportbot-nextcloud
bot
added
the
backport-request
|
/backport to stable21 |
|
/backport to stable20 |
This was referenced Jul 19, 2021
backportbot-nextcloud
bot
removed
the
backport-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #134
Signed-off-by: szaimen [email protected]